Update public_bookcase.json - Add more fields#1001
Update public_bookcase.json - Add more fields#1001tyrasd merged 5 commits intoopenstreetmap:mainfrom
Conversation
Adds moreFields capacity, colour, height, support and moves lit from fields to moreFields.
|
🍱 Preview the tagging presets of this pull request here: https://pr-1001--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Add books field
Adds fields books, direction
tyrasd
added
new-field
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Usually, I use the popularity of tag combinations to determine which fields to offer by default and which to include as optional fields. See below for some instances where I noticed that the preset would not match this rule of thumb.
Also, the books field should pobably allow for a multi-selection (see also the inline comment below).
| "fields": [ | ||
| "name", | ||
| "public_bookcase/type", | ||
| "books", |
There was a problem hiding this comment.
I would have said that for public bookcases, it is rather the exception to find only specific types of books. For this reason, I would have put this field to the moreFields section.
There was a problem hiding this comment.
It is already exception they are mapped, let alone such tags being discovered by users, but it is fine to change it.
| "books", | ||
| "operator", | ||
| "capacity", | ||
| "lit" |
There was a problem hiding this comment.
The lit tag seems to be a relatively popular combination (see taginfo: https://taginfo.openstreetmap.org/tags/amenity=public_bookcase#combinations). Why hide it?
There was a problem hiding this comment.
For clarity, it is moved to moreFields. (it is not hidden if people can easily discover it)
I think it is overall more of an exception they are lit, although relatively popular now.
Similarly, I think it is exception people will use a bookcase at night (except in areas with longer nights).
Otherwise I also don't think it is significant property of object itself, like for advertising (only on few ones on public squares).
(Here also it is fine to change it.)
| "operator", | ||
| "capacity", | ||
| "lit" | ||
| "direction" |
There was a problem hiding this comment.
The direction tag is not used very commonly on public bookcases. What's the intention behind offering the field by default for these features?
There was a problem hiding this comment.
So it can be more easily discovered.
direction in general is not often used, because it is not directly a object/access type.
However, it is often found on/near barrier and usually only accesible from one side.
It is recommended to add direction to such objects to prevent ambiguity with its position relative to other objects.
(similar to cameras, defibrillators, etc.)
(Here also it is fine to change it.)
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Thanks for the feedback. I've changed the field type to allow multiple values and tweaked the label to also fit other uses of the tag (e.g. on book shops or libraries). I've also reverted the field "ordering" to match the usage/popularity of the attributes for now.
2 participants
In general,
books(also used on book shops etc.).For public bookcase,
books,directioncolour,height,support. However, it seems height is already supported on any object, eventhough not all presets need this.litfrom fields to moreFields.Ignored:
boothorbuildingkey.internet_access(yes/wlan) and/orinscriptionexist.fee=yes(58 uses) this one.width/length, useful for nodes (1 use) this one.material(58 uses) is used but also included inpublic_bookcase:type. This seems somewhat of a tagging issue.recycling:books,charityandsecond_handare used by WikiProject:CircularEconomy but mostly in France.reuse:policy,reuse:books,reuse:facility. It is used by Public bookcase map, see source code.PS: Made a typo in the first commit saying
capacitywas added but it is still the same.